Skip to content

Conversation

@hhhyyo
Copy link
Contributor

@hhhyyo hhhyyo commented Mar 11, 2022

PR Type

What kind of change does this PR introduce?

  • 버그를 수정했어요.
  • 새로운 기능을 추가했어요.
  • 코드 스타일 업데이트를 했어요(포맷팅, 지역변수)
  • 리팩토링을 했어요 (기능적인 변화 없이, api 변경 없이)
  • 환경설정을 변경했어요.
  • 문서 내용을 변경했어요.
  • 기타 사항을 설명해 주세요.

Related Issues

#43

What does this PR do?

  • GlobalStyle 적용
  • MemoryRouter 적용

Other information

@hhhyyo hhhyyo added the ⚙️ conf 환경 설정 세팅이에요 label Mar 11, 2022
@hhhyyo hhhyyo added this to the Sprint1 milestone Mar 11, 2022
@hhhyyo hhhyyo self-assigned this Mar 11, 2022
Copy link
Contributor

@hustle-dev hustle-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스토리북을 배우면서하다보니 decorator 패턴을 처음보았는데 이런식으로 사용하는 군요..

<GlobalStyle />
<Story />
</MemoryRouter>
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정확히 Memory Router가 어떤 역할을 하는 지 궁금합니다. 🧐

Copy link
Contributor Author

@hhhyyo hhhyyo Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://v5.reactrouter.com/web/api/MemoryRouter
공식문서에서 메모리에 "URL"의 기록을 유지하는 Router입니다.(주소 표시줄을 읽거나 쓰지 않음). 테스트 및 React Native와 같은 비 브라우저 환경에서 유용합니다. 라고 적혀있습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hustle-dev hustle-dev merged commit 997adc6 into TeamCooks:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ conf 환경 설정 세팅이에요

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants